search

jupyterhub / zero-to-jupyterhub-k8s

Helm Chart & Documentation for deploying JupyterHub on Kubernetes
https://zero-to-jupyterhub.readthedocs.io
Other
1.56k stars 799 forks source link

docs: how to configure OAuthenticator client_id and client_secret via an existing k8s Secret #3478

Open AliaksandrTsimokhau opened 3 months ago

AliaksandrTsimokhau commented 3 months ago

Add a working example of using predefined secret to store ouath client credentials to avoid storing them on github. Example is based on forum discussion https://discourse.jupyter.org/t/jupyterhub-to-github-authentication-using-secrets/19380

consideRatio commented 2 months ago

Thank you @AliaksandrTsimokhau!!

I'd like to position this documentation as a way to configure the OAuthenticator based classes client_id and client_secret information from an chart external k8s Secret instead of the chart managed k8s Secret.

I think this documentation belong in this project as its chart specific configuration and not just about the oauthenticator project, but since its not a GoogleOAuthenticator specific documentation I'd like to lift it upwards a bit instead and make it focus just on configuring client_id and client_secret using an existing k8s Secret without in case that is a requirement. I think if we instead of putting it under a Google heading, we can put it as its own heading on the same level as the Google heading. For example above the GitHub Heading here:

image

AliaksandrTsimokhau commented 2 months ago

Hi Erik, Yep, it looks good to me. I only want to make it visible for others who wish to manage these values via k8s secrets. Thanks for the review.

ср, 18 сент. 2024 г. в 13:32, Erik Sundell @.***>:

Thank you @AliaksandrTsimokhau https://github.com/AliaksandrTsimokhau!!

I'd like to position this documentation as a way to configure the OAuthenticator based classes client_id and client_secret information from an chart external k8s Secret instead of the chart managed k8s Secret.

I think this documentation belong in this project as its chart specific configuration and not just about the oauthenticator project, but since its not a GoogleOAuthenticator specific documentation I'd like to lift it upwards a bit instead and make it focus just on configuring client_id and client_secret using an existing k8s Secret without in case that is a requirement. I think if we instead of putting it under a Google heading, we can put it as its own heading on the same level as the Google heading. For example above the GitHub Heading here:

image.png (view on web) https://github.com/user-attachments/assets/be89dcee-c8ec-4107-9a8e-73ce4e442bb3

— Reply to this email directly, view it on GitHub https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/3478#issuecomment-2358109542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZXZNSAY7DKMVZF3MZCPT3ZXFJDZAVCNFSM6AAAAABMEXBDX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJYGEYDSNJUGI . You are receiving this because you were mentioned.Message ID: @.***>

-- Regards, Aliaksandr Tsimokhau @.***