search

jupyterhub / zero-to-jupyterhub-k8s

Helm Chart & Documentation for deploying JupyterHub on Kubernetes
https://zero-to-jupyterhub.readthedocs.io
Other
1.56k stars 799 forks source link

Ensure hub container is first by appending instead of prepending hub.extraContainers #3546

Closed consideRatio closed 1 month ago

consideRatio commented 1 month ago

By doing this, you'd be able to do kubectl logs deploy/hub and get the hub containers logs no matter what. Before, you'd get the first listed hub.extraContainer instead and have to add --container=hub to ensure getting the hub containers logs.

I'm maintaining a deployment where we use hub.extraContainers, and by doing so, have been required to specify -c hub anytime I want logs, because its not the first container in the pod specs list of containers.

consideRatio commented 1 month ago

@yuvipanda @sgibson91 @GeorgianaElena the need to specify -c hub when getting hub logs for 2i2c hubs has bugged me a while, this fixes it and makes us instead need to specify hub.extraContainers in the hub pod by name if we want their logs.