search

jupyterlab-contrib / jlab-enhanced-launcher

Alternative launcher for JupyterLab
BSD 3-Clause "New" or "Revised" License
26 stars 11 forks source link

list view: icons too large #37

Open nick-youngblut opened 2 years ago

nick-youngblut commented 2 years ago

When I click on list view, many of the icons on the start of each list entry are too large:

Screen Shot 2022-09-19 at 5 13 18 PM

JupyterLab Version 3.4.7

MacOS v12.5.1, MacBook Pro (13-inch, M1, 2020)

fcollonval commented 2 years ago

Thanks for reporting @nick-youngblut

Would you be willing to open a PR to fix that? I can provide pointers.

nick-youngblut commented 2 years ago

Sure, but I'd need a lot of pointers. I don't even now where to begin

fcollonval commented 2 years ago

The good way is

  1. to open the development tools in your browser
  2. to select the element, you want to edit
  3. to add new CSS rule

See example in the below screencast - it demonstrate how to set the background-color of an icon.

test-style

You may need to search the web for your specific trouble as I cannot reproduce it (on Firefox on Windows).

Once you know what CSS rule needs to be set. You can open a PR modifying https://github.com/jupyterlab-contrib/jlab-enhanced-launcher/blob/master/style/table.css to add that new rule.

Don't hesitate to open the PR early even if it does not work so I can provide help.