Internalize @microsoft/fast-components

jupyterlab-contrib / jupyter-ui-toolkit

UI Toolkit for Jupyter

Other

41 stars 5 forks source link

Closed fcollonval closed 8 months ago

fcollonval commented 8 months ago

This PR internalizes the code from the deprecated package @microsoft/fast-components.

It also:

Update the color recipe to use an accentColor and a neutralColor design token easing the change of the theme
Adds the components: design-system-provider, disclosure, picker and skeleton.

Fixes #79

github-actions[bot] commented 8 months ago

:point_left: Launch a Binder on branch jupyterlab-contrib/jupyter-ui-toolkit/maintenance/internalize-fast-components

jtpio commented 8 months ago

Is that change temporary, so the warning reported in https://github.com/jupyterlab-contrib/jupyter-ui-toolkit/issues/79 does not show up in the yarn logs anymore?

If so, is there a long-term plan that would not require to vendor @microsoft/fast-components in this repo?

fcollonval commented 8 months ago

It is not temporary - it is definitive change.

jtpio commented 8 months ago

If so, is there a long-term plan that would not require to vendor @microsoft/fast-components in this repo?

And for this question?

Asking to get a better idea of the implications, and what that would mean in terms of maintenance work for maintainers in case this proposal is accepted: https://github.com/jupyterlab/team-compass/issues/227