search

jupyterlab-contrib / jupyter-videochat

Video chat with peers inside JupyterLab
https://jupyter-videochat.rtfd.io
BSD 3-Clause "New" or "Revised" License
60 stars 10 forks source link

RStudio addin #10

Open ntaback opened 3 years ago

ntaback commented 3 years ago

Is it possible to implement something like Jupyter-videochat as an RStudio addin?

bollwyvl commented 3 years ago

Very possibly! But probably not on this repository. Even installing rstudio in CI is a bit of a lift, and there are currently issues in binary compatibility between the nodejs required to build jupyterlab (12+) extensions and whatever it is that rstudio (10, EOL in <100 days) pushes out.

If anything, having the jupyter-videochat REST API better described (e.g. a schema or full OpenAPI spec) would allow rstudion browser clients (or any other frontend) to predictably connect to the same lightly-obfuscated Hub rooms, but the public room option in 0.5.0 would probably work...

yuvipanda commented 3 years ago

RStudio supports addins (https://rstudio.github.io/rstudioaddins/) which I think can support arbitrary js. Since this repo contains the python backend, I think it would be useful to write an rstudio addin for this that just embeds the jitsi plugin in there. I would also like one for classic notebook...

@bollwyvl do you have a pointer for where rstudio needs nodejs? I don't remember it requiring nodejs, and if it does I wanna make sure I'm not caught unaware :D

bollwyvl commented 3 years ago

Since this repo contains the python backend,

Happy to help tune up the server so the contract is more explicit! As the variety of clients increase, the value of schema/specs goes up. Better still might be speaking an existing standard, e.g. a subset of caldav.

I would also like one for classic notebook...

A jupyter widget could work in all of them, possibly (well, not rstudio) but then you've got a kernel (not a client) trying to resolve its list of rooms (if that's the primary thing beyond "open iframe").

@bollwyvl https://github.com/bollwyvl do you have a pointer for where rstudio needs nodejs?

I actually thought you had raised this point on gitter, something about rstudio requiring Debian system packages, etc. with the lab node build requirement being the problem.

yuvipanda commented 3 years ago

I actually thought you had raised this point on gitter, something about rstudio requiring Debian system packages, etc. with the lab node build requirement being the problem.

Ah, that's for binary packages of rstan

yuvipanda commented 3 years ago

A jupyter widget could work in all of them, possibly (well, not rstudio) but then you've got a kernel (not a client) trying to resolve its list of rooms (if that's the primary thing beyond "open iframe").

I was thinking instead of a self contained, small JS 'embed' that can be embedded anywhere - notebook, rstudio, random jupyterbook instance. It doesn't need all the features that exist in JupyterLab. Could just be the standard jitsi embed, just with Auth. I think that would be very useful