jupyterlab-contrib / jupyter-videochat

Video chat with peers inside JupyterLab
https://jupyter-videochat.rtfd.io
BSD 3-Clause "New" or "Revised" License
60 stars 10 forks source link

Update for JupyterLab 3, Router, Settings, etc. #14

Closed bollwyvl closed 3 years ago

bollwyvl commented 3 years ago

Sorry for the monster PR.

Binder

References:

Changes:

bollwyvl commented 3 years ago

questions on compatibility between notebook & jupyter_server packages

What's the flavor of concern? The nbclassic route works... but I don't know for how long. I could see issues arising prior to the hard cut at lab 4.x, but haven't been keeping track of the various lifecycle pieces.

A thing I'd really like to see is this working with voila (likely as a separate package), which is already jupyter_server-only.

As for integration with other UIs... I don't think the design constraints of jupyterlab-classic lend itself very well to this extension, as a dialog would be extremely unsatisfying, and if you start slamming more dom in the page... that might be resizable... and tabbed... well, sure sound like Lab at that point.

CR the labextension

Yeah, we had some events to run and needed some of the capability, so that initial PR kinda just kept going. Of course, shame on me for not having added better tests, but Always Be Demoing...

A follow-on could raise the browser testing game some... it would crack me up to have different CI bots talking to each other on Jitsi during CI

LINUX 3.9:     YO, WINDOWS, YOUR FILESYSTEM SO FAT, IT NEEDS 128 BITS
WINDOWS 3.6:   *CRIES*
MACOS 3.9:     BURN.

just merge it

cool, appreciated. I'll do another look over it, and re-request review... doing the binder shakedown i noticed some stuff, as it's the only hub-like-thing i have to test open source stuff. If you had any notes from it (not) working in your required hub setup, that would be rad. You can grab the tarballs from the dist asset.

bollwyvl commented 3 years ago

Alright, there are still some lingering issues with restoring a particular video chat after refreshing the browser... I think i messed up the commands somehow. Otherwise, shook down everything I found that was bothering me. I guess give it a spin and let me know what's missing from a functionality perspective. While working on it, had some ideas I'll hoist to follow-on issues.

bollwyvl commented 3 years ago

@yuvipanda thoughts?

yuvipanda commented 3 years ago

@bollwyvl I've hit the merge button :D Will you be able to do appropriate releases? <3

bollwyvl commented 3 years ago

:heart_eyes_cat: on it. I'll start a release ticket, and start shaking it down.