jupyterlab-contrib / jupyter-videochat

Video chat with peers inside JupyterLab
https://jupyter-videochat.rtfd.io
BSD 3-Clause "New" or "Revised" License
60 stars 10 forks source link

Quick access to creating a seperate browser tab which only comprises of the video chat #44

Closed honno closed 2 years ago

honno commented 3 years ago

Was using this nifty tool for the first time thanks to @tonyfast and folks inside a RTC Jupyter Labs session. As someone who's not familiar with Jupyter stuff outside of basic IPython cells, the experience was a bit too fun in that I found it hard to contextualise everything else going on in the Labs environment.

I'm sure I could of played around with the current sidebar feature and stuff but maybe there is room to improve that first-time user experience somehow. For example, if there was a button somewhere that would create a new tab that was just the video chat ala Google Meet.... just a first thought!

bollwyvl commented 3 years ago

Thanks for the interest.

Opening in another tab introduces a number of challenges from a future API integration point of view (e.g. #5, #24), but is probably feasible... but would not be my first choice as a default, however FANGMA does it. The ability to look at someone while doing something else is one of the features of having it in lab in the first place. Someone who's throwing you into a Lab session and piling Jitsi on top of it is being rather cavalier with your attention.

Under the hood, the thing's just an iframe, which should be openable as a new tab via right click... though Jitsi may have overloaded it (much like lab itself does) requiring a Ctrl+Shift+Click to get at it.

bollwyvl commented 3 years ago

The user story this might jive with is I'm using Jupyter for the first time with retrolab: in some (accidental) tests, we found that it pretty much works without any special case, though it's:

bollwyvl commented 3 years ago

Without too much jiggery-pokery, this looks okay:

what it looks like
add a New Video Chat button (also under _File->New) Screenshot from 2021-07-25 16-26-48
the pre-lobby Screenshot from 2021-07-25 16-25-13
in the chat Screenshot from 2021-07-25 16-24-49
in zen mode Screenshot from 2021-07-25 16-28-29
bollwyvl commented 3 years ago

Mostly working... #41 has a static one that you can try out right now:

https://jupyter-videochat--41.org.readthedocs.build/en/41/_static/lite/retro/tree/

bollwyvl commented 2 years ago

Fixed in v0.6.0.