jupyterlab-contrib / jupyter-videochat

Video chat with peers inside JupyterLab
https://jupyter-videochat.rtfd.io
BSD 3-Clause "New" or "Revised" License
60 stars 10 forks source link

Use more Lab core components #46

Closed bollwyvl closed 2 years ago

bollwyvl commented 3 years ago

Is your feature request related to a problem? Please describe.

The monolithic react component makes it very difficult to unwrap when something goes wrong and is not easily extensible by third- or first-party code without a prescriptive API. Additionally, hand-coding things to look like core components loses out on some of the benefits provided by lab, e.g. accessibility and themability improvements.

As a case in point, develop has currently picked up the seemingly-endemic issue of input tags thrashing on focus when value change.

Even if it was extensible, and robust, it would demand whatever downstream provider was using would need to be written in react.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

bollwyvl commented 2 years ago

This is mostly done now... to get all the way to e.g. a mimerenderer would take a bit more, but it's much better as of v0.6.0.