jupyterlab-contrib / jupyterlab-contrib.github.io

Management and website of JupyterLab Unofficial Extensions and Tools
https://jupyterlab-contrib.github.io/
BSD 3-Clause "New" or "Revised" License
44 stars 23 forks source link

jupyterlab-code-formatter #74

Closed ryantam626 closed 2 months ago

ryantam626 commented 3 months ago

Target

Reason

Haven't got the time to give this project attention for some time now.

Checklist

You must enable two-factor authentication on GitHub

fcollonval commented 3 months ago

Thanks a lot for your great extension and for proposing the transfer @ryantam626

in order to transfer the extension to this organization, you will need to carry out action on three web services:

Note: for transferring the package, you may be granted extensive rights that will be reduced later on to reduce hacker attack surface.

Don't hesitate to ping me here if you have questions or troubles with the above steps.

krassowski commented 3 months ago

:tada: cross-referencing https://github.com/ryantam626/jupyterlab_code_formatter/issues/339.

Just to note this down, after the transfer I would like to:

ryantam626 commented 3 months ago

Hey

fcollonval commented 3 months ago

Thanks @ryantam626 for the quick reaction.

I updated your rights on npm. You should be able to transfer the package now.

fcollonval commented 3 months ago

Let me know if you have issue with it.

ryantam626 commented 3 months ago

👍 @fcollonval - i think i have done it, the UI is extremely confusing 😓

fcollonval commented 3 months ago

I can confirm it has been transferred.

Thanks again for helping to quickly move forward on this.

Follow up for myself:

krassowski commented 3 months ago

https://github.com/jupyterlab-contrib/jupyterlab_code_formatter/pull/346 is ready for review :) I will be AFK until late in the evening.

fcollonval commented 3 months ago

@ryantam626 I missed that you have linked a personal sponsor account for the project. Is it ok if we remove it?

ryantam626 commented 3 months ago

@fcollonval of course!

krassowski commented 3 months ago

It looks like we are nearly there! I tried releasing 3.0 (version bump to indicate that Lab 4.x is now required), but run onto a branch protection rule config issue:

image

krassowski commented 3 months ago

I aligned the branch protection rules to allow admins, It is now failing on PyPI upload step:

Fetching PyPI OIDC token...
Fetching PyPI API token...
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.9/x64/bin/jupyter-releaser", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py", line 121, in invoke
    super().invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py", line 685, in publish_assets
    lib.publish_assets(
  File "/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/lib.py", line 405, in publish_assets
    twine_token = python.get_pypi_token(release_url, python_package_path)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/python.py", line [157](https://github.com/jupyterlab-contrib/jupyterlab_code_formatter/actions/runs/10042258208/job/27752284026#step:4:160), in get_pypi_token
    return fetch_pypi_api_token()
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/python.py", line 140, in fetch_pypi_api_token
    r.raise_for_status()
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/requests/models.py", line 1024, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 422 Client Error: Unprocessable Entity for url: https://pypi.org/_/oidc/github/mint-token

Does it ring any bells @fcollonval?

fcollonval commented 3 months ago

I did not set up the release workflow on pypi 😅 if you want to do it: https://pypi.org/manage/project/jupyterlab-code-formatter/settings/publishing/

krassowski commented 3 months ago

Thanks! I populated the form, uploaded artifacts manually and undrafted the GitHub release. We can test the workflow next time. Anything else to do before we close this issue?

fcollonval commented 2 months ago

No I think we are good --> closing this issue

Big thanks again to @ryantam626 to allow this great extension to move in this organization.

ryantam626 commented 2 months ago

well it's me that should be thanking you guys for your hard work 😸 - Thank you!