jupyterlab-contrib / jupyterlab-filesystem-access

[Experimental] Browse local files using the non-standard File System Access API
https://jupyterlab-filesystem-access.readthedocs.io
BSD 3-Clause "New" or "Revised" License
31 stars 6 forks source link

Update to JupyterLab 4 #55

Closed jtpio closed 11 months ago

jtpio commented 11 months ago

Fixes #31 Fixes #54 Fixes #57 Closes https://github.com/jupyterlab-contrib/jupyterlab-filesystem-access/pull/32

lite-badge

image

image

jtpio commented 11 months ago

Looking good at first:

image

Some dev tools errors that might be related to the update:

image

jtpio commented 11 months ago

While the current JupyterLite version seems to be working fine accessing files from the kernel:

image

Using this branch with the latest jupyterlite-*packages gives the following error:

image

jtpio commented 11 months ago

Checking with jupyterlite-pyodide-kernel==0.2.0a2, jupyterlite-core==0.2.0rc1 and the current version of jupyterlab-filesystem-access (0.5.3, the extension is built against JupyterLab 3 but activates fine in JupyterLab 4):

image

So this might be more of an issue with the latest jupyterlite-* packages when accessing drive content from the kernel, than an issue with this PR updating to JupyterLab 4.

jtpio commented 11 months ago

Hopefully this will be fixed in https://github.com/jupyterlite/jupyterlite/pull/1227.

jtpio commented 11 months ago

Getting this one in to follow-up with https://github.com/jupyterlab-contrib/jupyterlab-filesystem-access/issues/58.

martinRenou commented 11 months ago

Great thanks!