jupyterlab-contrib / jupyterlab-link-share

JupyterLab Extension to easily share a link to a running server on Binder
BSD 3-Clause "New" or "Revised" License
53 stars 14 forks source link

Show correct URL when using retrolab #27

Closed yuvipanda closed 2 years ago

yuvipanda commented 2 years ago

Fixes https://github.com/jupyterlab-contrib/jupyterlab-link-share/issues/25

yuvipanda commented 2 years ago

Should I not commit yarn.lock, @jtpio?

jtpio commented 2 years ago

There is a new dependency so the changes in yarn.lock are expected.

You can run jlpm (or yarn) locally and the conflicts should be fixed automatically (yarn does it for you)

jtpio commented 2 years ago

I think this is the right way to detect if we are in retrolab?

For now yes. I think the LSP extension uses a similar approach.

yuvipanda commented 2 years ago

@jtpio great! done.

jtpio commented 2 years ago

Thanks!

Maybe we could also add a .binder folder to install retrolab so it can easily be tested on Binder?

We would also need a postBuild that looks similar to this one: https://github.com/jupyterlab/retrolab/blob/main/binder/postBuild

jtpio commented 2 years ago

Maybe we could also add a .binder folder to install retrolab so it can easily be tested on Binder?

We can do that in a separate PR.

yuvipanda commented 2 years ago

@jtpio great! Think you can do a release this time too? :D

jtpio commented 2 years ago

Sure. Unless you would like to give it a try with the releaser (requires a bit of (one time) setup though).

yuvipanda commented 2 years ago

@jtpio i'll do that next week for sure!

jtpio commented 2 years ago

Nice, thanks!

Releasing now.

jtpio commented 2 years ago

@yuvipanda https://github.com/jupyterlab-contrib/jupyterlab-link-share/releases/tag/v0.2.4

yuvipanda commented 2 years ago

@jtpio great, deployed!