Closed yuvipanda closed 2 years ago
Should I not commit yarn.lock, @jtpio?
There is a new dependency so the changes in yarn.lock
are expected.
You can run jlpm
(or yarn
) locally and the conflicts should be fixed automatically (yarn does it for you)
I think this is the right way to detect if we are in retrolab?
For now yes. I think the LSP extension uses a similar approach.
@jtpio great! done.
Thanks!
Maybe we could also add a .binder
folder to install retrolab
so it can easily be tested on Binder?
We would also need a postBuild
that looks similar to this one: https://github.com/jupyterlab/retrolab/blob/main/binder/postBuild
Maybe we could also add a .binder folder to install retrolab so it can easily be tested on Binder?
We can do that in a separate PR.
@jtpio great! Think you can do a release this time too? :D
Sure. Unless you would like to give it a try with the releaser (requires a bit of (one time) setup though).
@jtpio i'll do that next week for sure!
Nice, thanks!
Releasing now.
@jtpio great, deployed!
Fixes https://github.com/jupyterlab-contrib/jupyterlab-link-share/issues/25