search

jupyterlab-contrib / jupyterlab-link-share

JupyterLab Extension to easily share a link to a running server on Binder
BSD 3-Clause "New" or "Revised" License
53 stars 14 forks source link

Update to JupyterLab 4 #59

Open andrii-i opened 1 year ago

andrii-i commented 1 year ago

Description

Currently when trying to use with JupyterLab 4, errors out with 

The following packages are incompatible
├─ jupyterlab-link-share 0.3**  is installable and it requires
│  └─ jupyterlab >=3.0.0,<4 , which can be installed;

Reproduce

Attempt to use with JupyterLab 4

Expected behavior

Works with JupyterLab 4

Context

Trying to update dependencies in https://github.com/jupyterlab/jupyterlab-demo

krassowski commented 1 year ago

Thank you for opening the issue.

@andrii-i FWIW in jupyterlab-demo we can drop this extension as jupyterlab-collaboration will ship with its own way of sharing links (https://github.com/jupyterlab/jupyter_collaboration/pull/150) so jupyterlab-link-share will no longer be required for RTC. I started this few days ago on a branch, please see my commits: https://github.com/jupyterlab/jupyterlab-demo/tree/lab-4.0 - the problem is that jupyterlab-collaboration has not been released yet (we can use alpha but I decided to just wait, and since then we got another alpha).

jtpio commented 1 year ago

Does the share link feature in jupyter-collaboration work on Binder when there are two servers running with one proxied?

This was also asked in https://github.com/jupyterlab/jupyter_collaboration/pull/150#issuecomment-1545743030 but I'm not sure about the status of it.

krassowski commented 1 year ago

It seems to be working fine with binder using https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab-4.0?urlpath=lab over at https://github.com/jupyterlab/jupyterlab-demo/pull/115. It is a bit unexpected that the link sharing dialog opens by clicking at an icon in top right corner while this extension was adding a menu item (I was looking in the left collaboration panel and all over menus).

krassowski commented 1 year ago

when there are two servers running with one proxied?

Is this the usual Binder setup?

jtpio commented 1 year ago

Is this the usual Binder setup?

Probably not. At some point it was used for the JupyterLab dev Binder by starting JupyterLav dev mode as a separate server via jupyter-server-proxy. But I don't think this is the case anymore.

andrii-i commented 1 year ago

@krassowski, @jtpio, thank you for replies and looking into this.