search

jupyterlab-contrib / jupyterlab-link-share

JupyterLab Extension to easily share a link to a running server on Binder
BSD 3-Clause "New" or "Revised" License
53 stars 14 forks source link

Archive this repository #60

Closed fcollonval closed 1 year ago

jtpio commented 1 year ago

Thanks @fcollonval.

Pinging @yuvipanda and @minrk who also contributed to this repo, to make sure archiving it is fine with them too.

minrk commented 1 year ago

Does jupyter-collaboration address #54? jupyter-collaboration also explicitly recommends installing this extension in its docs. And does it still work to use collaboration to generate links with tokens when RTC is unavailable? If not, it doesn't really seem to replace this extension at all.

fcollonval commented 1 year ago

Does jupyter-collaboration address #54?

image

The dialog has a checkbox that you introduced to include or not the token. But I guess there is still the need to add a server settings for admin to control that behavior.

jupyter-collaboration also explicitly recommends installing this extension in its docs.

Thanks I opened a PR to remove it

And does it still work to use collaboration to generate links with tokens when RTC is unavailable? If not, it doesn't really seem to replace this extension at all.

This indeed is a good point for not archiving the repository.

fcollonval commented 1 year ago

Closing this as per the discussion conclusion.