jupyterlab-contrib / jupyterlab-open-url-parameter

JupyterLab extension to open files passed via a URL parameter.
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Improve integration with Notebook 7 #16

Closed jtpio closed 8 months ago

jtpio commented 9 months ago

Fixes https://github.com/jupyterlab-contrib/jupyterlab-open-url-parameter/issues/14.

Opening a notebook

jupyterlab-open-url-paramater-notebook.webm

Open a file

jupyterlab-open-url-parameter-edit.webm

github-actions[bot] commented 9 months ago

Binder :point_left: Launch a Binder on branch jtpio/jupyterlab-open-url-parameter/nb7

yuvipanda commented 8 months ago

Anything that can help move this forward? :D

jtpio commented 8 months ago

Anything that can help move this forward? :D

We can address your suggestions above, and then it should be good to go for a new release.

yuvipanda commented 8 months ago

Sounds great! I think this is ready to come out of draft and be merged / released? (I don't have rights in this repo)

jtpio commented 8 months ago

There are still a couple of rough edges, for example the file name not being shown properly in the URL after loading the file. And also since the file is downloaded, there is the popup asking to overwrite the file next time a user opens the same URL (which is technically expected, although could become annoying).

But it's usable. So we could indeed merge, release, and fix the remaining issues later?

jtpio commented 8 months ago

(I don't have rights in this repo)

I added you to the repo.

We're using the Jupyter Releaser for making the releases. It's just a matter of triggering GitHub workflows: https://jupyter-releaser.readthedocs.io/en/latest/get_started/making_release_from_repo.html

If you would like to give it a try, we can use next as the version spec which should bump the version to 0.2.1. Otherwise I'm also happy to do the release.

yuvipanda commented 8 months ago

And also since the file is downloaded, there is the popup asking to overwrite the file next time a user opens the same URL (which is technically expected, although could become annoying).

Would this occur in jupyterlite even if you're just using the memory storage backend?

yuvipanda commented 8 months ago

yay for more rights :) Although I think in this case you shouldn't wait for me, just do the release when you feel it's right.

For me, if this doesn't have the overewrite dialog show up in the memory backend, it's good to go :)

jtpio commented 8 months ago

Would this occur in jupyterlite even if you're just using the memory storage backend?

Good point, it should indeed not store the file if enabled.

We can add it to the ReadTheDocs demo deployment to check if it works as expected.

jtpio commented 8 months ago

We can add it to the ReadTheDocs demo deployment to check if it works as expected.

To test it: https://jupyterlab-open-url-param--16.org.readthedocs.build/en/16/lite/notebooks/?fromURL=https://raw.githubusercontent.com/jupyterlab/jupyterlab-demo/master/notebooks/Lorenz.ipynb

jtpio commented 8 months ago

To test it: https://jupyterlab-open-url-param--16.org.readthedocs.build/en/16/lite/notebooks/?fromURL=https://raw.githubusercontent.com/jupyterlab/jupyterlab-demo/master/notebooks/Lorenz.ipynb

For reference opening the same link looks fine after enabling the memory storage on the demo RTD deployment:

open-url-parameter-jupyterlite-memory-storage.webm

jtpio commented 8 months ago

@yuvipanda 0.3.0 is released: https://github.com/jupyterlab-contrib/jupyterlab-open-url-parameter/releases/tag/v0.3.0