jupyterlab-contrib / jupyterlab-spreadsheet-editor

JupyterLab spreadsheet editor for tabular data (e.g. csv, tsv)
BSD 3-Clause "New" or "Revised" License
135 stars 7 forks source link

Disable conflicting JSpreadsheet export #71

Closed renan-r-santos closed 4 months ago

renan-r-santos commented 5 months ago

Fixes https://github.com/jupyterlab-contrib/jupyterlab-spreadsheet-editor/issues/70.

Since its shortcut conflicts with JupyterLab's default save shortcut, and users can always use the Download option in JupyterLab's menu, I believe the simplest solution is to disable JSpreadsheet's export feature.

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a binder notebook on branch renan-r-santos/jupyterlab-spreadsheet-editor/fix-save-shortcul-conflict

renan-r-santos commented 4 months ago

Hi @krassowski, sorry for the ping, but I noticed you recently worked on this repo to add support for JupyterLab 4 (thanks a lot, btw) and thought you might be the right person to ask. Would you be able to take a look at this small change? Thanks!

krassowski commented 4 months ago

@renan-r-santos released in https://github.com/jupyterlab-contrib/jupyterlab-spreadsheet-editor/releases/tag/v0.7.2