Add jupyter releaser workflows

jupyterlab-contrib / jupyterlab-topbar

JupyterLab Top Bar extensions

BSD 3-Clause "New" or "Revised" License

108 stars 17 forks source link

Add jupyter releaser workflows #95

Closed mahendrapaipuri closed 1 year ago

mahendrapaipuri commented 1 year ago

Added jupyter-releaser workflows and a CHANGELOG.md file generated by github-activity.

jtpio commented 1 year ago

Thanks @mahendrapaipuri!

Wondering if we could use the python_packages field of the releaser to specify all the Python packages in the monorepo? Like the jupyverse project does here: https://github.com/jupyter-server/jupyverse/blob/b3c3589ef71d9b8088fb86cea3c92746ea05d49b/pyproject.toml#L144-L164

We could check if it is working by looking at the uploaded artifacts by the check release workflow on CI.

mahendrapaipuri commented 1 year ago

This is what exactly I am looking at. As we do not have a pyproject.toml on the root of the repo, we will have to add a .jupyter-releaser.toml for config. JupyterLab is using sort of a dummy package name for the root package.json and using build-before-npm hook to build the packages. We should be able to do the same right?

We need to add script to package.json to bump versions of all individual packages though.

jtpio commented 1 year ago

We could also have a pyproject.toml at the root level of the repo to hold the configuration I guess.

mahendrapaipuri commented 1 year ago

@jtpio I tried to integrate the check-release workflow but with some strong assumptions.

Added a dummy python package in the top-level directory and version in package.json. We should make sure that the version in the top level directory should be in sync will all packages.
We cannot make individual release to a package. Everytime we run release workflows, all package versions will be bumped. Given that they are all pure TS extensions, maybe we can live that?

If we can pass --python-packages arg at runtime, I think we can control the individual package release. But I guess that is not possible at the moment? Let me know, what do you think!

I have also reverted the versions of all packages so that we can bump them to 1.0.0 with jupyter-releaser. Replaced hypens with underscores in the package folders to get valid wheels.

cccs-nik commented 1 year ago

Any updates on this @jtpio? I would like to use the new version of jupyterlab-topbar for JupyterLab 4.0 🙂

jtpio commented 1 year ago

I think we should be good to go.

Maybe we can grab the latest version of the workflows from the releaser repo to get the proper configuration for using the PyPI trusted publishers: https://github.com/jupyter-server/jupyter_releaser/blob/main/example-workflows/publish-release.yml

jtpio commented 1 year ago

Also it looks like we can version all the packages together for now, although in the long run it would be nice to allow versioning packages independently.

mahendrapaipuri commented 1 year ago

Also it looks like we can version all the packages together for now, although in the long run it would be nice to allow versioning packages independently.

@jtpio Agree! Lets do a release for Jupyterlab 4.0 now and we will see how we can version packages independently!

mahendrapaipuri commented 1 year ago

@jtpio Just checking in to see if there is anything missing in this PR to get it merged and do a release?

jtpio commented 1 year ago

@mahendrapaipuri yes it should be good to go!

Merging now, will try to get a release out today. Thanks again!

jtpio commented 1 year ago

Merging now, will try to get a release out today. Thanks again!

Just tried the prep release workflow specifying 1.0.0 as the version but it bumped to 0.6.1 instead:

Looks like there might be an issue when reading the new version after the bump.