Fix search box `Esc` bindings

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab

https://jupyterlab-contrib.github.io/jupyterlab-vim.html

MIT License

660 stars 43 forks source link

Fix search box `Esc` bindings #107

Closed firai closed 10 months ago

firai commented 10 months ago

Fixes #104. PR courtesy of @krassowski.

Delete Esc → documentsearch:end bindings for notebooks.
Add data-jp-vim-mode-name=mode class to CodeMirror instances, where mode can be "normal", "insert", "visual" or "visual block".
Change file editor Esc → documentsearch:end bindings' .cm-vimMode selectors to [data-jp-vim-mode-name='normal'].

github-actions[bot] commented 10 months ago

:point_left: Launch a Binder on branch firai/jupyterlab-vim/del-search-box-bindings

krassowski commented 10 months ago

Thank you for the PR @firai. Would you mind testing the commit I pushed (https://github.com/jupyterlab-contrib/jupyterlab-vim/pull/107/commits/36294d8cdbe935d89582cfb8e918bec283282b4a)?

firai commented 10 months ago

Thanks, @krassowski! Seems to work well. I updated the description.

By the way, feel free to open a new branch and PR for this, as this is mostly your work. I just left this PR in case you wanted to merge directly from here.

ianhi commented 10 months ago

@firai this and #105 should be available in version 4.0.3 thanks for the contribution :)