search

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
660 stars 43 forks source link

Please respect Jupyterlab settings for non-blinking cursor #109

Open gloryVine opened 10 months ago

gloryVine commented 10 months ago

Hi. The blinking cursor in jupyterlab was an issue in the past, see e.g. here and here. This was ultimately resolved by providing the user with the ability to set cursorBlinkRate to zero. This also worked with jupyterlab-vim in the past. However, when I again started using it recently, I noticed that the cursor is now blinking again in all browsers, despite the above setting. Is there a way to make jupyterlab-vim respect the jupyterlab setting, or is there another way to disable cursor blinking?

krassowski commented 10 months ago

What version of jupyterlab-vim and Jupyterlab version are you using?

gloryVine commented 10 months ago

Jupyterlab 4.0.5 and jupyterlab-vim 4.0.3 on macOS Ventura 13.4. Browsers tried were Firefox, Chromium and Safari.

krassowski commented 10 months ago

The extension was rewritten for JupyterLab 4.0, and depends on https://github.com/replit/codemirror-vim/. That however seems to hard-code the blinking rate. One would need to open an issue upstream to make it respect the current configuration of drawSelection extension from @codemirror/view.

Issue: https://github.com/replit/codemirror-vim/issues/140

firai commented 7 months ago

The fix/feature has been merged upstream. Now we just have to wait for a new release.

firai commented 7 months ago

@krassowski What's the right way to update the versions of @codemirror/view and @replit/codemirror-vim in the package? Should I just delete yarn.lock and let it re-populate, or should package.json and yarn.lock be edited manually to strictly control the versions of other packages?

krassowski commented 7 months ago

I would suggest to