jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
660 stars 43 forks source link

Constraints on giving people triage/write permissions #112

Open ianhi opened 9 months ago

ianhi commented 9 months ago

Are there any basic rules of jupyterlab-contrib for giving contributors triage and/or write permissions, @krassowski @fcollonval ?

There have been some consistent contributors (both code and otherwise) to this repo that I'd like to offer increased permissions to.

krassowski commented 9 months ago

There is a template in https://github.com/jupyterlab-contrib/jupyterlab-contrib.github.io/issues/new anyone can fill it if they would like to help with maintenance.

Edit: I was thinking about it to. I would think reaching out to folks encouraging them to fill in the ticket is one way going forward.

fcollonval commented 9 months ago

No rules are enforced and I'm basically accepting any requests. For a specific repository as in this case, maintainers should not be constrained by any organization rules. The issue template created at the organization level was initiated for two reasons:

But it could be interesting to ask new contributors to create that issue in all cases in order to:

krassowski commented 9 months ago

Based on the discussion above I extended invitation to the organisation and elevated rights to one of the active contributors in this repo :) I agree that in general we should encourage new contributors to open an issue, but maybe we should adjust the template or documentation to make it more welcoming/add another template implying a lower level of commitment (some folks may want to help by regular contributions but may not want to commit to higher level of maintenance like releases and it is perfectly fine).

firai commented 9 months ago

Thanks for inviting me!

ianhi commented 9 months ago

Based on the discussion above I extended invitation to the organisation and elevated rights to one of the active contributors in this repo :) I

That's exactly who I was thinking of :) - thanks for all the contributions @firai !