search

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
660 stars 43 forks source link

Change `Ctrl + Enter` to render Markdown cells #128

Closed firai closed 7 months ago

firai commented 7 months ago

References

Closes #120

Code changes

Don't re-enter edit mode for Markdown cells in vim:run-cell-and-edit.

Additional context

This command has been contradictory for Markdown cells, as JL exits edit mode when rendering Markdown by design. This command previously prioritized staying in edit mode, which effectively resulted in no actions being taken for Markdown cells when the command is called.

Since the user pressed a key binding to call the command and therefore presumably expected something to happen, I think this proposed change to prioritize rendering the cell for Markdown cells is acceptable.

github-actions[bot] commented 7 months ago

Binder :point_left: Launch a Binder on branch firai/jupyterlab-vim/ctrl-enter-render-md

SamLau95 commented 6 months ago

Thanks so much!

ianhi commented 5 months ago

@firai this still needs to be released right?

firai commented 5 months ago

Correct, this hasn't been released yet

ianhi commented 5 months ago

do you have the poewr to make a release? if not im happy to do it, and also to try to figure out getting you the ability.

instructions on how live here: https://jupyter-releaser.readthedocs.io/en/latest/get_started/making_release_from_repo.html