Fix scrolling on `g g` and `G`

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab

https://jupyterlab-contrib.github.io/jupyterlab-vim.html

MIT License

660 stars 43 forks source link

Fix scrolling on `g g` and `G` #137

Closed krassowski closed 4 months ago

krassowski commented 4 months ago

Closes #134

To add more context, we should make this change anyways, because otherwise scrolling would not work in the full windowing mode.

github-actions[bot] commented 4 months ago

:point_left: Launch a Binder on branch krassowski/jupyterlab-vim/scrolling-fix-for-lab-4.1

ianhi commented 4 months ago

This does indeed fix the scrolling but I think it's doing something weird to selection state of the cell. When i do this I have to hit enter twice in order to get to cell edit (vim normal) mode. In contrast when in jupyter command mode if I move up a cell with j then it only takes one enter press to accomplish the same.