jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab

https://jupyterlab-contrib.github.io/jupyterlab-vim.html

MIT License

691 stars 43 forks source link

Update `codemirror-vim` to 6.2.1 and `jupyterlab` to 4.2.0 #146

Closed firai closed 2 months ago

firai commented 2 months ago

References

Fixes #109, amongst other bug fixes and enhancements in codemirror-vim (https://github.com/replit/codemirror-vim/compare/v6.0.14...v6.2.1).

Code changes

Bump codemirror-vim to 6.2.1.
Bump jupyterlab packages to 4.2.0 to get updated @codemirror/view for #109.
Add guards for possible null for cm.state.vim, introduced by codemirror-vim (https://github.com/replit/codemirror-vim/pull/162).

Known issues

Not introduced by this PR, but #138 is still broken. JL 4.1, which introduced the new behavior, was already required since #135, so this PR does not (by itself) make the conflict unavoidable.

github-actions[bot] commented 2 months ago

:point_left: Launch a Binder on branch _firai/jupyterlab-vim/bump_cm-vimver

firai commented 2 months ago

Hi @krassowski and @ianhi, can either of you help release a new version? It seems like I don't have the permissions to do so. Not sure if it's worth mentioning #138 as a known issue in the release notes.

krassowski commented 2 months ago

Not sure if this has to do with your permissions, it failed for me too: https://github.com/jupyterlab-contrib/jupyterlab-vim/actions/runs/10880534712 I think the token has expired, let me set it up for the trusted publishers mechanism

krassowski commented 2 months ago

Ok, after https://github.com/jupyterlab-contrib/jupyterlab-vim/pull/147 and a few tweaks in the settings the release came through: https://github.com/jupyterlab-contrib/jupyterlab-vim/releases/tag/v4.1.4 - you should be able to update the release notes manually now :)