search

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
688 stars 43 forks source link

Status line font color conflict in Jupyterlab Dark Theme #153

Open HereticSK opened 6 days ago

HereticSK commented 6 days ago

Description

When setting the theme to Jupyterlab Dark, there is a font color conflict in status line. The text typed in the status line can not be seen due to font color issue. It can only be shown when highlighted with a mouse.

I found this after upgrading both Jupyterlab to 4.3.0 and jupyterlab-vim to 4.1.4. Dont know which one causes this issue.

1 2

Reproduce

Either open a text file in a text editor, or open a .ipynb file, hit :s or search with /

Context

firai commented 2 days ago

Looking at the ex prompt with the browser inspector, it seems like the panel is themed with CodeMirror mechanisms, and it doesn't seem like codemirror-vim is introducing any custom CSS rules or classes to cause the mismatch with the editor theme. Therefore, it seems like addressing this at the JupyterLab level would be more appropriate, instead of trying to hack the ͼ2 or cm-panels rules in the extension? @krassowski, do you have any suggestions?

image

krassowski commented 2 days ago

Yes, it looks like this should be resolved in JupyterLab as .cm-panels is a class from @codemirror/view theme. I think a rule to override it would go in here. PR welcome!