jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
676 stars 43 forks source link

Allow enable/disable via settings? #24

Closed asford closed 3 years ago

asford commented 3 years ago

This appears to be the de-facto extension for jupyterlab 3.0, at least until https://github.com/jupyterlab/jupyterlab/pull/9068 lands. Would you be open adding settings-support in repo, so that this end-users can (at least) enable/disable the extension?

I would be happy to implement as a PR if you're open.

Work items:

axelfahy commented 3 years ago

Sure, you can implement those features if you want. However, it might be duplicated work if the extension lands directly with jupyterlab.

ianhi commented 3 years ago

I haven't had time to work on moving it into jlab and unfortunately may not for a while yet. So

  1. If anyone wants to push that work on jlab forward they should feel free to (also welcome to ping me for reviews)
  2. A short term fix for this would make sense
  3. What should probably happen is that jupyterlab-vimrc should be folded into this repo in order to have only a single settings file for all vim related things.
mlucool commented 3 years ago

This has been implemented in https://github.com/axelfahy/jupyterlab-vim/pull/32

dclong commented 3 years ago

I thought users can use jupyter server extension enable/disable to enable/disable an extension? However, it seems that the command doesn't work with jupyterlab-vim.

dclong commented 3 years ago

Is there a way to disable jupyterlab-vim for all users? I want to install the extension but keep it disabled by default since not all users are familiar with vim keybindings.

dclong commented 3 years ago

Never mind. I figured out that the right command to use is jupyter labextension disable @axlair/jupyterlab_vim instead of jupyter labextension disable jupyterlab_vim.