Move to packaging@0.9 - Githubissues

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab

https://jupyterlab-contrib.github.io/jupyterlab-vim.html

MIT License

662 stars 43 forks source link

Move to packaging@0.9 #34

Closed mlucool closed 3 years ago

mlucool commented 3 years ago

Please finish the following when submitting a pull request:

[ ] Add a line to History.md briefly documenting the change.

If this is a release, additionally do the following:

[ ] Update the dependencies in package.json
[ ] Run jlpm install to update yarn.lock

Thanks!

github-actions[bot] commented 3 years ago

:point_left: Launch a binder notebook on branch mlucool/jupyterlab-vim/upgrade-packaging

mlucool commented 3 years ago

I don't really understand the error here:

Successfully installed jupyterlab-vim-0.13.6 Error: Process completed with exit code 1.

mlucool commented 3 years ago

@ianhi can you kick this off again? I think I fixed the build issue

ianhi commented 3 years ago

I wonder why it still thinks you're a first time contributor. We merged a PR from you already??

Also it look as though I was wrong in the last PR about how the automated version bumping work and we ended up on 0.13.6 instead of 0.14.0. I don't think I have adequate rights to modify settings for that, so for now we'll need to manually bump to 0.14.0 (and then get auto bumped to .0.14.1...)

Also, is this a real failure or is this warning just causing CI to be unhappy?

WARNING: Value for scheme.headers does not match. Please report this to https://github.com/pypa/pip/issues/9617 distutils: /opt/hostedtoolcache/Python/3.7.10/x64/include/python3.7m/UNKNOWN sysconfig: /opt/hostedtoolcache/Python/3.7.10/x64/include/python3.7m

ianhi commented 3 years ago

Would it help to move to using build since we aren't making an editable install?

mlucool commented 3 years ago

I wonder why it still thinks you're a first time contributor. We merged a PR from you already??

No idea, but can you kick it off one more time? I only modified one of the github workflows last time, so I think copy/pasting it to the other should work too now.

Also, is this a real failure or is this warning just causing CI to be unhappy?

I didn't know what that was, but I don't think it is the problem.

ianhi commented 3 years ago

This is good - but I can't seem to push to your fork to bump the version. I'd like to do that here before the automated release goes and makes a release of 0.13.7 so can you bump us to 0.14.0 and then I'll merge?

mlucool commented 3 years ago

Version has been bumped to 0.14.0

ianhi commented 3 years ago

Awesome - thanks @mlucool !