search

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
662 stars 43 forks source link

restore get_data_files in setup.py #35

Closed ianhi closed 3 years ago

ianhi commented 3 years ago

I think we missed this part of https://github.com/jupyterlab/extension-cookiecutter-ts/pull/143 in #34

github-actions[bot] commented 3 years ago

Binder :point_left: Launch a binder notebook on branch _axelfahy/jupyterlab-vim/datafiles

mlucool commented 3 years ago

I was debugging this as we speak. Yes, that looks right!

ianhi commented 3 years ago

I was debugging this as we speak. Yes, that looks right!

:tada: - sorry I missed it in my earlier review!

ianhi commented 3 years ago

https://github.com/axelfahy/jupyterlab-vim/actions/runs/811471564 for publishing

Should probably rework the publish script so that it tries installing the wheel and checks for issues like this before uploading to pypi

mlucool commented 3 years ago

Agreed - as pip install -e does not catch this it seems