search

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
661 stars 43 forks source link

Clear search #43

Closed mlucool closed 1 year ago

mlucool commented 2 years ago

After pressing / there is no way to clear a matched search on a cell (unless of course you search for something not there). Can we clear search on entering nothing?

search

ianhi commented 2 years ago

This is actually the same as normal vim bevhior (at least in my terminal installation). The way to clear the search is with :noh.

It might be kind of nice to have something like https://github.com/junegunn/vim-slash but that probably belongs as as separate plugin that works with codemirror itself.

mlucool commented 2 years ago

Yeah - turns out it was a mapping that maps / to clear also. Thoughts on doing something similar here (opt-in)?

ianhi commented 2 years ago

It feels like this ought to already be possible with https://github.com/ianhi/jupyterlab-vimrc#jupyterlab-vimrc although it may require some actual coding as in https://discuss.codemirror.net/t/possible-vim-leader-key-work-around/3006/4 as I'm not sure how well ex mappings work for the codemirror vim implementation

peytondmurray commented 1 year ago

I think this issue can be closed now - somehow I forgot to target this issue in the related PR. Sorry!

krassowski commented 1 year ago

Closing as fixed by #74.