build fails with node 17+

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab

https://jupyterlab-contrib.github.io/jupyterlab-vim.html

MIT License

691 stars 43 forks source link

build fails with node 17+ #60

Closed Coleej closed 1 year ago

Coleej commented 2 years ago

Building against node 17+ fails because of new crypto library. Node throws the error "Error: error:0308010C:digital envelope routines::unsupported".

Workarounds are either downgrade node or set the environmental variable NODE_OPTIONS="--openssl-legacy-provider" when running build commands.

I'm not familiar with yarn/npm packages or I would add this to the configs where appropriate. Also just wanted let people know about the workarounds without having to Google.

ianhi commented 2 years ago

I noticed this too. In general I think there is more success when using one of the nodejs LTS releases (e.g. 14 or 16). When releasing we always use one of those.

@Coleej out of curiosity why were you trying to build this manually?

krassowski commented 1 year ago

Closing as we are now testing against Node 18 (v18.17.1 as of today).