jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
661 stars 43 forks source link

`0.15.0` broken - cannot use 'c' key #63

Closed shinypond closed 2 years ago

shinypond commented 2 years ago

After the latest update, the key 'c' is unavailable when the insert mode of vim.

Is this a bug?

Description

Reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error '...'

Expected behavior

Context

Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Web Browser Output
Paste the output from your browser web console here.
ianhi commented 2 years ago

Hi @shinypond thanks for reporting!

Is this a bug?

If this is happening consistently in 0.15.0 and not in 0.14.5 then it is almost certainly a bug :(.

Can you please confirm that if you downgrade jlab vim to 0.14.5 in the same environment then c works again?

ianhi commented 2 years ago

oh boy. It sure it broken. That's really not great. I wish we had tests that could check things like this.

shinypond commented 2 years ago

Thanks for your reply!!

I have just installed jlab vim through the jupyter lab extension tab(leftside in the web), without any terminal command such as pip. Then how can I downgrade jlab vim to 0.14.5? Use pip install?

Anyway, I hope this problem be solved soon...

ianhi commented 2 years ago

I have just installed jlab vim through the jupyter lab extension tab(leftside in the web)

hmm. I don't know much about how to use that. I would in the terminal do the following:

jupyter labextension uninstall @axlair/jupyterlab_vim
pip install jupyterlab-vim==0.14.5

Anyway, I hope this problem be solved soon...

me too :disappointed: . Looking around I havne't been able to figure out the cause. If other people could put some eyes on it that'd be really helpful! Full diff here: https://github.com/jupyterlab-contrib/jupyterlab-vim/compare/0.14.5...0.15.0

ianhi commented 2 years ago

Oh wow - you can't even type the letter c I though you just couldn't do things like ciw. That's really bad. Worth considering pulling that release off pypi if it's not an obvious fix. I'm going to bed but can try to think more about this tomorrow

shinypond commented 2 years ago

Okay. Thanks for your efforts. Have a good night!

ianhi commented 2 years ago

I spoke too soon :) I may have i figured it out

ianhi commented 2 years ago

now I don't think i can sleep until I at least try this

ianhi commented 2 years ago

ok. Thanks again for reporting!

new version should be published as soon as https://github.com/jupyterlab-contrib/jupyterlab-vim/runs/5520553204?check_suite_focus=true finished (and then conda-forge version a few hours later)

ianhi commented 2 years ago

@shinypond if you get a chance could you try out the new version and confirm that it works for you? Now it truly is bedtime for me i think

shinypond commented 2 years ago

Everything is now okay!!! Thanks a lot @ianhi !!

wiseyoungbuck commented 2 years ago

Thanks a bunch. Quite excited to have this back.