jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
661 stars 43 forks source link

Should we detach the fork? #78

Closed krassowski closed 1 year ago

krassowski commented 1 year ago

I just lost quite some time trying to push to #69 to fix up the lint errors before merging. It seems that while the PR author agreed maintainers to modify it:

Screenshot from 2023-03-12 22-38-02

It looks that github rejects my edits when pushed from local repo. This is strange as I can push via GitHub UI. I believe it is related to this repository being a fork and the PR fork being associated with jwkvam/jupyterlab-vim rather than jupyterlab-contrib/jupyterlab-vim.

firai commented 1 year ago

Deforking was discussed in #66, but it hasn't happened yet for whatever reason

krassowski commented 1 year ago

Closing as duplicate of #66.