TYPO: Update installing.md uninstall command

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab

https://jupyterlab-contrib.github.io/jupyterlab-vim.html

MIT License

691 stars 43 forks source link

TYPO: Update installing.md uninstall command #81

Closed nikisix closed 1 year ago

github-actions[bot] commented 1 year ago

:point_left: Launch a binder notebook on branch nikisix/jupyterlab-vim/patch-1

firai commented 1 year ago

@ianhi @krassowski Should we delete installing.md and mention of "JupyterLab <3", i.e. JupyterLab 2, in README altogether? It seems to me that the duplication of information is cause of this typo.

krassowski commented 1 year ago

I agree with the idea of deleting it, the less duplication the better.

firai commented 1 year ago

Hi @nikisix, thanks for noticing the typo and submitting the PR! Since the extra installation.md only exists to provide JL 2 extension instructions and since JL 2 is quite old now, we think it may be best to delete this file altogether. I hope you don't mind us modifying your PR to do so.

firai commented 1 year ago

Sorry, I didn't notice that a rebase would be required, which is probably more work than it's worth. I have opened a new PR at #121. Please take a look.

I'll close this PR. Thanks for your contribution!