undo with `u` does not work on jupyterlab 4

[navdeeprana]

Thank you so much for maintaining and porting the extension to jupyterlab 4. I upgraded to the latest versions of both and undo with u does not work. Ctrl-Z does.

[lukashergt]

I can confirm, u within a cell does not work.

In "jupyter" mode, you can create a new cell with o and undo that with u.

[ianhi]

Thanks for reporting! I can confirm that I experience this. I wonder if this is the same cause as https://github.com/jupyterlab-contrib/jupyterlab-vim/issues/31 where we were colliding with a default jupyter shortcut somehow.

It's not because we switched to the new codemirror vim as it's works here: https://replit.com/@util/codemirror-vim

[ianhi]

maybe related to https://github.com/jupyterlab/jupyterlab/issues/14113

[ianhi]

digging deeper still it seems that undo has become a more complicated action in jupyterlab 4. probably to help with the real time collab stuff. It seems as though ctrl-Z isn't handled by codemirror, but rather by jupyterlab. in particular I think it ends up calling this funciton: https://github.com/jupyterlab/jupyterlab/blob/659c6113a97cb906c8b90867a1fe916e628547f2/packages/codemirror/src/editor.ts#L263-L265

so we'll need to end up overriding what u does and have it call that funciton somehow

[krassowski]

That's doable. I can open a PR on top of #90.

[krassowski]

PR is up: https://github.com/jupyterlab-contrib/jupyterlab-vim/pull/92

[ianhi]

fix is now released.

pip install --upgrade jupyterlab-vim

[navdeeprana]

thank you so much for the quick fix