jupyterlab-contrib / rise

RISE: "Live" Reveal.js JupyterLab Slideshow Extension
BSD 3-Clause "New" or "Revised" License
157 stars 16 forks source link

Cells not executable in slideshow mode #43

Open fjhickernell opened 10 months ago

fjhickernell commented 10 months ago

Description

After installing jupyterlab-rise, I can see the meta data tags for choosing which kind of slide. However, in slideshow view the slides are not executable, even though they are in Jupyter notebook with RISE

Reproduce

  1. Create a Jupyter notebook in Jupyter Lab that contains executable Python code.
  2. Using Common Tools, assign the cells to be Slides
  3. Invoke slideshow mode
  4. In slideshow mode edit code and execute cell

Expected behavior

The output of the cell should change based on what has been entered, but it does not.

Context

Name: jupyterlab Version: 4.0.5 Summary: JupyterLab computational environment

Read the migration plan to Notebook 7 to learn about the new features and the actions to take if you are using extensions.

https://jupyter-notebook.readthedocs.io/en/latest/migrate_to_notebook7.html

Please note that updating to Notebook 7 might break some of your extensions.

[I 2023-08-20 16:49:20.498 ServerApp] nbclassic | extension was successfully loaded. [I 2023-08-20 16:49:20.499 ServerApp] Serving notebooks from local directory: /Users/fredhickernell/SoftwareRepositories/QMCSoftware [I 2023-08-20 16:49:20.499 ServerApp] Jupyter Server 2.5.0 is running at: [I 2023-08-20 16:49:20.499 ServerApp] http://localhost:8888/lab?token=a1eae46522caa3410e2c86172877701381af7482dd20d07f [I 2023-08-20 16:49:20.499 ServerApp] http://127.0.0.1:8888/lab?token=a1eae46522caa3410e2c86172877701381af7482dd20d07f [I 2023-08-20 16:49:20.499 ServerApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation). [C 2023-08-20 16:49:20.503 ServerApp]

To access the server, open this file in a browser:
    file:///Users/fredhickernell/Library/Jupyter/runtime/jpserver-31583-open.html
Or copy and paste one of these URLs:
    http://localhost:8888/lab?token=a1eae46522caa3410e2c86172877701381af7482dd20d07f
    http://127.0.0.1:8888/lab?token=a1eae46522caa3410e2c86172877701381af7482dd20d07f

[I 2023-08-20 16:49:20.519 ServerApp] Skipped non-installed server(s): bash-language-server, dockerfile-language-server-nodejs, javascript-typescript-langserver, jedi-language-server, julia-language-server, pyright, python-language-server, python-lsp-server, r-languageserver, sql-language-server, texlab, typescript-language-server, unified-language-server, vscode-css-languageserver-bin, vscode-html-languageserver-bin, vscode-json-languageserver-bin, yaml-language-server [W 2023-08-20 16:49:23.417 LabApp] Could not determine jupyterlab build status without nodejs [W 2023-08-20 16:49:23.819 ServerApp] Notebook demos/talk_paper_demos/Purdue_Talk_2023_March/Purdue_Talk_Figures.ipynb is not trusted [I 2023-08-20 16:49:24.071 ServerApp] Kernel started: 5603f017-6677-4a14-a198-f4f4c047697a [I 2023-08-20 16:49:24.483 ServerApp] Connecting to kernel 5603f017-6677-4a14-a198-f4f4c047697a. [I 2023-08-20 16:49:24.485 ServerApp] Connecting to kernel 5603f017-6677-4a14-a198-f4f4c047697a. [I 2023-08-20 16:49:24.485 ServerApp] Connecting to kernel 5603f017-6677-4a14-a198-f4f4c047697a.

Web Browser Output
Paste the output from your browser web console here.
nthiery commented 10 months ago

Just as a data point: I did not manage to reproduce; with the same jupyterlab 4.0.5 and rise 0.40.0, I can execute cells as expected.

Ubuntu 22.04, Firefox, Python 3.11.5

nthiery commented 10 months ago

Ah wait, this could be related to #17: if a code cell already has content, then that content is executed. But if there is no initial content, whatever is typed in is ignored, and the cell is executed as an empty cell. Which looks as if the cell had not been executed.

trevorcampbell commented 9 months ago

I can reproduce this. Screencast from 2023-09-11 03:19:02 PM.webm

Try for yourself by running JupyterLab in the following docker image with command (and visit the URL in your browser):

docker run --rm -v $(pwd):/home/jovyan/work -p 8889:8889 ubcdsci/r-dsci-100-grading:18f638381ca6 jupyter lab --port 8889
jupyter_client                8.3.1
jupyter_core                  5.3.1
jupyter-events                0.7.0
jupyter-lsp                   2.2.0
jupyter_server                2.7.3
jupyter-server-mathjax        0.2.6
jupyter_server_terminals      0.4.4
jupyter-telemetry             0.1.0
jupyterhub                    4.0.2
jupyterlab                    4.0.5
jupyterlab_git                0.42.0
jupyterlab-pygments           0.2.2
jupyterlab_rise               0.40.0
jupyterlab_server             2.24.0
jupyterlab-widgets            3.0.8
trevorcampbell commented 9 months ago

Ah, I should have posted my response in #48 , which I think is more what is going on in my case.

fiware-austria commented 9 months ago

To it looks as if the keyboard shortcut "shift-enter" does not longer execute the cell but navigates to the next slide.

bneumayer commented 9 months ago

I am having the same issue. The notebook seems to overrule the content in presentation mode, which does the following:

Maybe there is an issue with the separation of "Command Mode" and "Edit Mode"? The cells (in notebook view and presentation mode) are always marked blue but they should be green when in "Edit Mode", if I remember correctly. Also, the shortcuts seem to be "always on", e.g., when I wanted to type # Addition into a cell in presentation mode the speaker view opened when I typed 't'.

AnotherCodeArtist commented 9 months ago

I had to downgrade to version 0.2.0 to get it working again. Maybe that helps!

Would be great to get this working, since it is one of the killer-features, that sets rise apart from other presentation tools.

bneumayer commented 9 months ago

I had to downgrade to version 0.2.0 to get it working again. Maybe that helps!

Would be great to get this working, since it is one of the killer-features, that sets rise apart from other presentation tools.

At our institution we used a combination of downgrading and opening the notebook in Nbclassic - not perfect but all functionalities work at the moment.

nthiery commented 9 months ago

Just for information: I have been using lately JupyterLab-Deck. There remains a few caveats (JupyterLab 3.6 only, broken space / shift-space navigation with sublides, no conda package), but other than this it has done the job for me.

briank-git commented 8 months ago

If your use case allows for JupyterLab 3, I found that cells appear to work normally and run with changes with JupyterLab 3.6.6 and RISE 0.3.0.

trevorcampbell commented 5 months ago

FWIW: after PR #62 was merged, I can now reliably edit and execute code in RISE slides.