jupyterlab-contrib / rise

RISE: "Live" Reveal.js JupyterLab Slideshow Extension
BSD 3-Clause "New" or "Revised" License
182 stars 18 forks source link

Add factory token for jupytext customization #50

Closed fcollonval closed 1 year ago

fcollonval commented 1 year ago

This:

Fixes partly https://github.com/jupyterlab-contrib/rise/issues/17#issuecomment-1699442075 cc @nthiery

This will need to be backported on 3.x and then a PR will be required on jupytext itself (code already written and tested https://github.com/fcollonval/jupytext/tree/ft/support-lab-rise).

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a Binder on branch jupyterlab-contrib/rise/enh/create-token-file

fcollonval commented 1 year ago

@meeseeksdev please backport to 3.x

lumberbot-app[bot] commented 1 year ago

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:

    git cherry-pick -x -m1 e8dedca3690c3b1d0812d18bc23c9febb24cd925
  2. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #50: Add factory token for jupytext customization'
  1. Push to a named branch:
git push YOURFORK 3.x:auto-backport-of-pr-50-on-3.x
  1. Create a PR against branch 3.x, I would have named this PR:

"Backport PR #50 on branch 3.x (Add factory token for jupytext customization)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval commented 1 year ago

Jupytext PR is up: https://github.com/mwouts/jupytext/pull/1126