search

jupyterlab-contrib / rise

RISE: "Live" Reveal.js JupyterLab Slideshow Extension
BSD 3-Clause "New" or "Revised" License
157 stars 16 forks source link

Fix Custom CSS URL Possible Double Slash #60

Closed sinanbekar closed 4 months ago

sinanbekar commented 7 months ago

This PR fixes custom CSS HTTP request errors when starting JupyterLab server with the same folder as the .ipynb file.

Fixes https://github.com/jupyterlab-contrib/rise/issues/27

Example URL: http://localhost:8888/files//rise.css

403 : Forbidden
The error was:

/rise.css is not in root static directory
github-actions[bot] commented 7 months ago

Binder :point_left: Launch a Binder on branch sinanbekar/rise/patch-1

f0k commented 4 months ago

Ran into the same issue, found the same fix (removing the double slash), thank you for doing the PR! The fix looks reasonable to me (I would have hacked in curdir && (curdir + '/') somewhere, but yours looks more elegant). Anyone up to merging it? From the build checks, it seems there is still a formatting problem, and the PR should have a bug label. Assuming that this held the maintainers back, @sinanbekar, do you think you can correct the formatting?

sinanbekar commented 4 months ago

Ran into the same issue, found the same fix (removing the double slash), thank you for doing the PR! The fix looks reasonable to me (I would have hacked in curdir && (curdir + '/') somewhere, but yours looks more elegant). Anyone up to merging it? From the build checks, it seems there is still a formatting problem, and the PR should have a bug label. Assuming that this held the maintainers back, @sinanbekar, do you think you can correct the formatting?

Hey @f0k, the lint error was caused by the main branch (package.json). I synced the PR to main. I think it's fine now.