jupyterlab-contrib / rise

RISE: "Live" Reveal.js JupyterLab Slideshow Extension
BSD 3-Clause "New" or "Revised" License
157 stars 16 forks source link

Opening notes exits full screen slides #74

Open trevorcampbell opened 4 months ago

trevorcampbell commented 4 months ago

Issue

When the slides are full screen, hitting "T" to open the notes brings the slides out of full screen mode.

Screencast from 2024-02-27 02:33:54 PM.webm

Reproduce

  1. Open a slides notebook, click the presentation button.
  2. Full screen the slides by clicking the button in the presentation tab.
  3. Press T to open the notes.

The slides will exit from full screen.

Expected behavior

I would expect the notes window to come up without exiting full screen slides.

Context

Using Chrome Version 122.0.6261.69 (Official Build) (64-bit).

Output of pip list | grep jupyter

jupyter_client                8.4.0
jupyter_core                  5.4.0
jupyter-events                0.8.0
jupyter-lsp                   2.2.0
jupyter-resource-usage        1.0.1
jupyter_server                2.8.0
jupyter-server-mathjax        0.2.6
jupyter_server_terminals      0.4.4
jupyter-telemetry             0.1.0
jupyterhub                    4.0.2
jupyterlab                    4.0.7
jupyterlab_git                0.50.0
jupyterlab-pygments           0.2.2
jupyterlab_rise               0.42.0
jupyterlab_server             2.25.0
jupyterlab-widgets            3.0.9

Output of jupyter labextension list

JupyterLab v4.0.7
/opt/conda/share/jupyter/labextensions
        jupyterlab_pygments v0.2.2 enabled  X (python, jupyterlab_pygments)
        nbgrader v0.9.1 enabled OK (python, nbgrader)
        jupyterlab-rise v0.42.0 enabled OK (python, jupyterlab_rise)
        nbdime-jupyterlab v3.0.1 enabled OK
        @jupyter-notebook/lab-extension v7.0.6 enabled OK
        @jupyter-widgets/jupyterlab-manager v5.0.9 enabled OK (python, jupyterlab_widgets)
        @jupyterlab/git v0.50.0 enabled OK (python, jupyterlab-git)
        @jupyter-server/resource-usage v1.0.1 enabled OK (python, jupyter-resource-usage)

   The following extensions are outdated:
        jupyterlab_pygments

   Consider checking if an update is available for these packages.

Disabled extensions:
    @jupyterlab/cell-toolbar-extension (all plugins)