search

jupyterlab-contrib / rise

RISE: "Live" Reveal.js JupyterLab Slideshow Extension
BSD 3-Clause "New" or "Revised" License
182 stars 18 forks source link

mermaid is not work in slideshow #76

Open SepCode opened 6 months ago

SepCode commented 6 months ago

mermaid is not work in slideshow

djstrong commented 6 months ago

It would be very helpful to support mermaid.

apohllo commented 6 months ago

Is there any way we could contribute to this issue? Where should we look, to check why the extension is not working? Mermaid diagrams were recently integrated with Jupyter Lab, so having them in RISE should be easy to implement. I guess this boil down to calling a method, when a certain type of Markdown code (i.e. ```mermaid) is recognized in the text cell.

krassowski commented 6 months ago

Mermaid diagrams were added in https://github.com/jupyterlab/jupyterlab/pull/14102. It might be as simple as adding the new packages to https://github.com/jupyterlab-contrib/rise/blob/main/packages/application/package.json and rebuilding but I am not familiar with the codebase here so its just a guess.

Y3drk commented 5 months ago

@krassowski

Mermaid diagrams were added in jupyterlab/jupyterlab#14102. It might be as simple as adding the new packages to https://github.com/jupyterlab-contrib/rise/blob/main/packages/application/package.json and rebuilding but I am not familiar with the codebase here so its just a guess.

Wanted to try that approach but encountered issues when trying to work in development mode (another issue listed on this repo).

Also when I tried forking it the dependencies install failed due to some inconsistency with webpack (no idea what that was about). Anyway after the forced install the build still failed.

The reason for that may or may not be in my setup / me using an npm instead of yarn as they do in project, but either way playing around with it is not so simple and I couldn't confirm your theory.

If you had tried it and had any luck with it I'd appreciate any info from you :)