Opening notebooks as notebooks, rather than as text files?

jupyterlab-contrib / search-replace

Search and replace accross files

BSD 3-Clause "New" or "Revised" License

23 stars 5 forks source link

Opening notebooks as notebooks, rather than as text files? #79

Open krassowski opened 2 years ago

krassowski commented 2 years ago

Opening files with matches from the sidebar is fine, but notebooks open as files for me. Scrolling to the cell with match should be easy enough when the match is in the cell. Is this a bug/something specific to my setup, or is it just not implemented?

Additional context

Python package version: 1.0.1
JupyterLab 3.4.3 but also seen that in a much older version

fcollonval commented 2 years ago

Thanks for the suggestion @krassowski.

That choice was made on purpose as the underlying tool (riggrep) can only deal with plain text file.

It is definitely possible to do something smarter. But it will require implementing a kind of registry for file types that will support a different behavior for opening a file and going to a specific match (with the ability to pick the default viewer).

fcollonval commented 2 years ago

Xref #75