jupyterlab-contrib / spellchecker

Spellchecker for JupyterLab notebook markdown cells and file editor.
BSD 3-Clause "New" or "Revised" License
204 stars 20 forks source link

Improve contrast for dark themes #45

Closed krassowski closed 3 years ago

krassowski commented 3 years ago

Fixes #41

File editor before:

Screenshot from 2021-02-08 21-03-39

File editor after:

Screenshot from 2021-02-08 21-06-47

Inactive cell before:

Screenshot from 2021-02-08 21-08-23

Inactive cell after:

Screenshot from 2021-02-08 21-07-58

Disclaimer: I do not see all the colors and it is just ok for me now (but the contrast could be even stronger). If I overdid this please reduce accordingly to your liking.

krassowski commented 3 years ago

Maybe alpha 0.3 would be enough. I do not know. This is tricky because increasing it too much reduces contrast with text. I think the reasonable range would be 0.25-0.4.

krassowski commented 3 years ago

I added dark text-shadow to improve contrast:

Screenshot from 2021-02-09 05-46-26

ijmbarr commented 3 years ago

Thanks!