search

jupyterlab / benchmarks

Benchmarking tools for JupyterLab
https://jupyterlab-benchmarks.readthedocs.io
BSD 3-Clause "New" or "Revised" License
12 stars 16 forks source link

Benchmarking lab 3.4.x. vs 3.0.x ? #116

Closed vidartf closed 2 years ago

vidartf commented 2 years ago

I added a manual run for seeing benchmarking 3.4.x vs 3.0.x but it failed: https://github.com/jupyterlab/benchmarks/actions/runs/2995288042

Is there a minimal version of the lab version that can be benchmarked?

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

fcollonval commented 2 years ago

The installation step was broken in JupyterLab due to a bug in the build tool hatch-jupyter-builder. That bug has been fixed. So I triggered the job a third time.

The benchmark tests should run on all 3.x versions. For earlier versions, it is also possible to test against JLab 1.x and 2.x by using the project jupyterlab-1-2. See for example https://github.com/jupyterlab/benchmarks/actions/runs/2919374023 that compares 3.2.5 and 1.2.19.

vidartf commented 2 years ago

Thanks! 👍

fcollonval commented 2 years ago

mmmh... apparently the accessibility role attribute was added later than 3.0. So the selectors are not working. You may give a try by using jupyterlab-1-2 for 3.0.x.