search

jupyterlab / benchmarks

Benchmarking tools for JupyterLab
https://jupyterlab-benchmarks.readthedocs.io
BSD 3-Clause "New" or "Revised" License
12 stars 16 forks source link

Playwright does not support chromium on mac11.4 #70

Open jess-x opened 3 years ago

jess-x commented 3 years ago

Description

Error when trying to run jlpm

benchmarks/packages/run/node_modules/playwright/lib/helper.js:325
        throw new Error(message);
              ^

Error: ERROR: Playwright does not support chromium on mac11.4

Reproduce

  1. Quick start benchmarks as instructed
  2. run jlpm

Expected behavior

benchmarks should be started without Playwright issue

Context

Troubleshoot Output 
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output 
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output 
Paste the output from your browser Javascript console here, if applicable.
welcome[bot] commented 3 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

echarles commented 3 years ago

Googled around and found a lot of similar reports. No solution, apart maybe on microsoft/playwright#5443

pip3 install playwright==1.8.0a1

and npm install playwright,then it worked. Playwright does not support chromium on mac11.2 ,which is sloved. python3 -m playwright codegen --target python -o new.py -b chromium:

from playwright.sync_api import sync_playwright

def run(playwright):
    browser = playwright.chromium.launch(headless=False)
echarles commented 3 years ago

... or try upgrading to the latest pre-release version.

saulshanabrook commented 3 years ago

It looks like we are currently pinning playwright to an old version, 1.3.0: https://github.com/jupyterlab/benchmarks/blob/ae6dece2a5615b1965312699c37c6b518e41e17b/packages/run/package.json#L20

Hopefully if we upgraded playwright to the latest, then this might be fixed.

EDIT: Nevermind, it still doesn't work on 1.13.0, the latest version.

saulshanabrook commented 3 years ago

Ah maybe if we pin to @next instead? https://github.com/microsoft/playwright/issues/7555#issuecomment-879250587

jess-x commented 3 years ago

I tried pinning to next, this:

      throw new Error(`Failed to download ${title}, caused by\n${e.stack}`);
            ^

Error: Failed to download webkit v1522, caused by
Error: Download failed: server returned code 404. URL: https://playwright.azureedge.net/builds/webkit/1522/webkit-mac-11.0-arm64.zip

sounded like arm-64 is not supported, maybe someone with non arm-64 can help run the benchmarks?

Galaxyjia commented 3 years ago

UnhandledPromiseRejectionWarning: Error: ERROR: Playwright does not support chromium on mac11.5

fcollonval commented 3 years ago

Cross-referencing that one: https://github.com/microsoft/playwright/issues/7723 For a potential work around using docker if it gets resolved.

fcollonval commented 3 years ago

I tagged it as won't fix as it requires some work upstream.