search

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
183 stars 88 forks source link

Remove the lib js target #122

Closed jtpio closed 3 years ago

jtpio commented 3 years ago

Since lib is pruned here:

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/fb8de6e99ee29ea0f11aecf1f49b044e1023e319/%7B%7Bcookiecutter.python_name%7D%7D/MANIFEST.in#L16

It will not be part of the sdist, and will be a missing js target. Which means that even with https://github.com/jupyterlab/extension-cookiecutter-ts/pull/121, it looks like it will still trigger a build.

Not sure we could rely on any other files in outputDir/static/ since their names are generated. So we might just want to keep outputDir/package.json?

jtpio commented 3 years ago

An alternative could be to also include lib alongside src instead:

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/fb8de6e99ee29ea0f11aecf1f49b044e1023e319/%7B%7Bcookiecutter.python_name%7D%7D/MANIFEST.in#L16

But that does not really correspond to the "real source" anymore.