search

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
179 stars 88 forks source link

Align linter with JupyterLab #131

Closed fcollonval closed 3 years ago

fcollonval commented 3 years ago

This is particularly important to support some Typescript features of 3.7+ https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.0.0

jtpio commented 3 years ago

Nice, thanks!

Something else noticed recently that we could add to this PR (or another one), is adding the outputDir ({{cookiecutter.python_name}}/labextension) to the .prettierignore file.

fcollonval commented 3 years ago

Something else noticed recently that we could add to this PR (or another one), is adding the outputDir ({{cookiecutter.python_name}}/labextension) to the .prettierignore file.

Would it make sense to ignore the all python folder rather than just the labextension subfolder?

jtpio commented 3 years ago

Would it make sense to ignore the all python folder rather than just the labextension subfolder?

Probably yes, at least for this cookiecutter.

Thinking that there might be other JS assets in the python package too in more complex projects, for example a classic notebook extension.