Fix jupyter-packaging pinning

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript

BSD 3-Clause "New" or "Revised" License

183 stars 88 forks source link

Fix jupyter-packaging pinning #151

Closed martinRenou closed 3 years ago

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

jtpio commented 3 years ago

Thanks Martin.

This could indeed be a stricter pin.

But I think the reasoning for having jupyter_packaging~=0.10,<2 is because the jupyter-packaging API changes are already in the latest release, and this should help ease the transition to 1.0. Also the Jupyter Packaging readme advertises using this pin, but of course extensions and other downstream projects are free to choose stricter pins.