search

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
183 stars 88 forks source link

Fix CI fail on initial push of newly created extension #154

Closed s-weigand closed 3 years ago

s-weigand commented 3 years ago

First of all thanks for the cookiecutter template ❤️

Sadly it doesn't always work out of the box.

When creating a new extension and choosing has_binder [n]: y the initial push fails due to check-manifest complaining about the binder folder not being in the MANIFEST.in. Since the binder settings aren't needed for the extension itself, this can be fixed by excluding them from packaging.

After fixing this there is an error caused by popd (directory stack empty) since pushd wasn't used in the workflow.

After removing popd from the workflow template a freshly created extension passes the CI.

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: