search

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
183 stars 88 forks source link

Let cookiecutter render check-release.yml #189

Closed xiaohk closed 3 years ago

xiaohk commented 3 years ago

The file check-release.yml should be rendered by cookiecutter because it uses cookiecutter variable cookiecutter.python_name (line 59).

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/6d1b8c628a2a944c6ef4bd23dcce51498b97c3dd/%7B%7Bcookiecutter.python_name%7D%7D/.github/workflows/check-release.yml#L59

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

xiaohk commented 3 years ago

Thanks @fcollonval! Agreed, your way to escape double curly brace (https://github.com/jupyterlab/extension-cookiecutter-ts/pull/189#discussion_r743440144) is much easier to read! I have committed the suggested change.

xiaohk commented 3 years ago

@fcollonval I am not sure why some test are timed out 🙁

fcollonval commented 3 years ago

Kicking CI

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: