search

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
182 stars 88 forks source link

Update versions of GH actions #249

Closed krassowski closed 1 year ago

krassowski commented 1 year ago

Gets rid of Node 12 deprecation warnings

krassowski commented 1 year ago

This PR and scheduled checks are failing on Python 3.11 with: ImportError: Error importing plugin "pytest_jupyter.jupyter_server": No module named 'pytest_jupyter'. I don't think pytest_jupyter is an explicit dependency in cookiecutter so I am a bit lost. @blink1073 is this something that needs to be fixed upstream in maintainer-tools or similar?

fcollonval commented 1 year ago

We need to explicitly use it by adding the dependency there

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/4fca73f34a69bb6ce1e88b4f7eef6d56d92c0c3d/%7B%7Bcookiecutter.python_name%7D%7D/pyproject.toml#L31

and switching the configuration there

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/4fca73f34a69bb6ce1e88b4f7eef6d56d92c0c3d/%7B%7Bcookiecutter.python_name%7D%7D/conftest.py#L3

The later command is the reason of the error because it ends up loading that configuration file requiring pytest_jupyter:

https://github.com/jupyter-server/jupyter_server/blob/main/jupyter_server/pytest_plugin.py

fcollonval commented 1 year ago

@meeseeksdev please backport to 3.0