search

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
179 stars 88 forks source link

Update sequential commands to use `run-s` #257

Closed joaopalmeiro closed 1 year ago

joaopalmeiro commented 1 year ago

For consistency purposes, if you agree, given that the npm-run-all package is a dev dependency and used in the watch command.

krassowski commented 1 year ago

Is there a benefit of using run-s over &&? I can see a potential downside because if we add commands with multiple arguments we would need to escape spaces, right?

joaopalmeiro commented 1 year ago

Is there a benefit of using run-s over &&? I can see a potential downside because if we add commands with multiple arguments we would need to escape spaces, right?

From my perspective, the benefits are consistency (although run-p has the extra benefit of being cross-platform) and shorter commands.

Yes, we would have to enclose the script in quotes (e.g., "lint": "run-s stylelint prettier \"eslint --debug\""), but that doesn't seem an issue to me because of how the commands are prepared.

joaopalmeiro commented 1 year ago

All right! What should I do about this PR? Or should I just wait for it to be closed and I don't need to do anything else?

fcollonval commented 1 year ago

Thanks for the ping @joaopalmeiro - as nobody else commented, I'll close it. If somebody has additional arguments, we can always reboot this.