search

jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
181 stars 88 forks source link

Upgrades binder nodejs version #271

Closed JasonWeill closed 1 year ago

JasonWeill commented 1 year ago

Upgrades the nodejs version used in new extensions' binder configs. Fixes #270.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

jtpio commented 1 year ago

@meeseeksdev please backport to 4.0

lumberbot-app[bot] commented 1 year ago

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.0
git pull

  1. Cherry pick the first parent branch of the this PR on top of the older branch:

    git cherry-pick -x -m1 e36f631c0f7bd02c6cf16fc9fb1e3d50aaccd101

  2. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #271: Upgrades binder nodejs version'
  1. Push to a named branch:
git push YOURFORK 4.0:auto-backport-of-pr-271-on-4.0
  1. Create a PR against branch 4.0, I would have named this PR:

"Backport PR #271 on branch 4.0 (Upgrades binder nodejs version)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.