jupyterlab / extension-cookiecutter-ts

A cookiecutter recipe for JupyterLab extensions in Typescript
BSD 3-Clause "New" or "Revised" License
179 stars 88 forks source link

Fix wrong version specifier #284

Closed a3626a closed 1 year ago

a3626a commented 1 year ago

python -m pip install jupyterlab>=4.0.0a29,<5 is not working and results this error during jupyter_releaser release action.

Running hooks for before-build-npm
/bin/sh: 1: cannot open 5: No such file
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.9/x64/bin/jupyter-releaser", line 8, in <module>
    sys.exit(main())
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/cli.py", line 119, in invoke
    util.run(hook)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/util.py", line 91, in run
    raise e
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/util.py", line 83, in run
    process = tee(cmd, **kwargs)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/tee.py", line 159, in run
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command 'python -m pip install jupyterlab>=4.0.0a29,<5' returned non-zero exit status 2.
welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

a3626a commented 1 year ago

And from my experience and github action test result, I have also found that this project(package.json) requries @types/react dev dependency, too. However I'm not sure that this cookiecutter template should include @types/react.

fcollonval commented 1 year ago

I'll open a follow up PR to add the @types/react as suggested by @a3626a to fix the CI.

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: